search

btroncone / ngrx-examples

@ngrx examples and resources
371 stars 68 forks source link

Removing respond-ng import #4

Closed onlyann closed 8 years ago

onlyann commented 8 years ago

The store example test file requires this dependency.

littleStudent commented 8 years ago

Thx for noticing. ng-respond is not really needed. Could you instead just remove line 7 in shop.spec.ts please? import RESPOND_PROVIDERS, {Respond} from 'respond-ng'; It is unused!

littleStudent commented 8 years ago

can you also remove "respond-ng": "0.0.2", from package.json again?

onlyann commented 8 years ago

Sorry for the history mess. It's the first time I perform a pull request.

btroncone commented 8 years ago

Looks great, congrats on first PR! Thanks!