btroncone / ngrx-store-localstorage

Simple syncing between @ngrx store and local storage
MIT License
610 stars 119 forks source link

migrate deepmerge to ts-deepmerge #254

Closed Neizan93 closed 1 year ago

Neizan93 commented 1 year ago

Summary

This PR migrates from the deepmerge library to ts-deepmerge, addressing an optimization warning in Angular 14 and later versions.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Current Behavior

When integrating ngrx-store-localstorage with Angular 14 and later versions, a warning related to the deepmerge dependency emerges due to its CommonJS or AMD nature. This warning indicates potential optimization bailouts.

Issue Number: #229

New Behavior

By transitioning to the ts-deepmerge library, the warning is resolved, and users benefit from improved TypeScript compatibility and enhanced type checking.

Breaking Change?

Other information

The change was inspired by feedback from the community and recommendations to use libraries with ESModules support. It's a step toward aligning ngrx-store-localstorage with modern JS standards and making it more future-proof.