btschwertfeger / python-kraken-sdk

Command-line tool and SDK to access the Kraken Cryptocurrency Exchange API (Spot, NFT & Futures, REST and Websocket API)
https://python-kraken-sdk.readthedocs.io/en/stable
Apache License 2.0
38 stars 19 forks source link

Feature proposal: Add proxy support #256

Closed Graeme22 closed 1 month ago

Graeme22 commented 1 month ago

Hi, thanks for this cool project!

One feature that is missing, which would be extremely easy to add, is proxies. Many people use them for anonymity, which is a good use case. In my case, I'd like to use a proxy to improve security by routing traffic through a specific IP and whitelisting that IP for API usage.

Describe the solution you'd like

Pretty straightforward: requests already supports this, so it's as simple as passing the argument through the constructors.

If desired I can submit a PR with the proposed changes for spot and futures REST clients.

btschwertfeger commented 1 month ago

Hallo @Graeme22, thank you for your suggestion. I will have a look into it myself and let you know!

btschwertfeger commented 1 month ago

Yeah that looks fine, feel free to open a PR!