search

btsimonh / hoverboard-firmware-hack

New Hoverboard Firmware Hack. Now written from scratch and generally much better.
GNU General Public License v3.0
22 stars 4 forks source link

custom commands (buzzer and lightweight speed/steer) #18

Closed p-h-a-i-l closed 5 years ago

p-h-a-i-l commented 5 years ago

added functionality to control Buzzer via protocol and a speed/steer control method which does not have all the overhead like SpeedData.

I don't remember if we agreed to a numbering scheme - I just picked some. Feel free to change.

btsimonh commented 5 years ago

@EmerickH - with your experience of this, is there meaning to using this as the maximum, but also being able to specify a current limit as part of a movement command - think of it as 'go here, but gently' vs 'go here, but push through the curtain'?

EmerickH commented 5 years ago

@btsimonh I don't think so I'm not totally sure of that but I think the max current is not directly changing the movement speed but it can have influence on the acceleration Personally I want to be able to change it is to adapt to different loads (weight on the wheels) and to the floor's adherence depending if it's wood, concrete...:

@p-h-a-i-l I did not understand exactly what your speed/steer control does, could you explain it to me?

@p-h-a-i-l & @btsimonh why not creating a Github team to gather this repository, p-h-a-i-l's newprotocol one and next projects on this? Any idea for the name?

p-h-a-i-l commented 5 years ago

@p-h-a-i-l I did not understand exactly what your speed/steer control does, could you explain it to me?

Same as SpeedData, but without all the overhead. In speed data a huge struct is transmitted all the time.

speed/steer might not be used anymore in the newprotocol branch. Speed is PWM and Steer is added or substracted for each wheel from Speed.

btsimonh commented 5 years ago

Hmm.... names are so hard to make catchy! ran a name generator, and my favourite results were: hovomeister firmwary boardinator hover-nova Bipropellant - this one strike me as quite nice! - fine if we stick to two wheel drive... We could go with phail's 'hacknology', but i think it's taken (good set of repos in that account!) :).

EmerickH commented 5 years ago

Bipropellant sounds good, I have not any other idea so OK! I just created a team and a new repository with the content of newprotocol (->master): @btsimonh that allows you can keep your own branches of hoverboard-f-h on this repo. I think it's better to not have a fork because it's annoying for pull requests and we are far from original project, anyway we'll still able to rebase on Niklas's firmware if there is some interesting changes You can transfer issues if you want

@p-h-a-i-l you can transfer your repo to the organization and change the link in .gitmodules?

p-h-a-i-l commented 5 years ago

hmm. I'm not sure if we should break wit Niklas' old code base. He's not really open to changes, But I like to honor the roots..

btsimonh commented 5 years ago

I'm in two minds. I avoided updating master in this repo, with the thought that eventually I'd hit a point where we could make a compelling pull request; but I've noted that the guys in that repo are not really looking for large changes. We can still acknowledge the roots in the readme, and if anyone ends up here from there, my readme can highlight the new repo. I think that they would also be open to highlighting our repo in their readme and the wiki? So far as I have seen, we're still the only OSS implementation of actual hoverboard functionality reproduction, and probably the most mature machine protocol based implementation (which surprises me!). @p-h-a-i-l - have you met that team? if so, maybe you could ask their thoughts?

p-h-a-i-l commented 5 years ago

We could go with phail's 'hacknology', but i think it's taken (good set of repos in that account!) :).

btw, hacKNology is the name of my local hackerspace :) Unfortunately the name was already taken by someone on github

@p-h-a-i-l - have you met that team? if so, maybe you could ask their thoughts?

Yeah, I met Niklas and Jan Henrik on the 35C3 and I'll probably see them at GPN. They apologized for not working on the pull requests, but were not too motivated to merge stuff. I think their intention is to have the code as a starting point for cool projects, but are not interested in adding lots of features. They started one approach with the transpotter branch to add specific configs and adaptions, but this went stale.. My pull request to merge https://github.com/p-h-a-i-l/hoverboard-firmware-hack is quite large, but solves a lot of problems people mention in their github issues and the chat room. It is now even referenced in the main repo for the serial interface. (I deviated from your branch since I couldn't get it stable on my board - but my goal is to merge both back together, the protocol was the first step :) )