search

btsimonh / hoverboard-firmware-hack

New Hoverboard Firmware Hack. Now written from scratch and generally much better.
GNU General Public License v3.0
22 stars 4 forks source link

Protocol on multiple UARTs #19

Closed p-h-a-i-l closed 5 years ago

p-h-a-i-l commented 5 years ago

change to allow protocol to be used on multiple UARTs at once.

Not tested yet :)

preparation to reuse these files also on my ESP32 to have an implementation for the other side.

btsimonh commented 5 years ago

I like it; my kind of change :).
I won't merge until you've given it a cursory test, as I'm not in a position to test, so ping me - even if it's just to confirm that it still works fine off a single port....

p-h-a-i-l commented 5 years ago

I hope I'll get the chance tomorrow. How do you feel to move all protocol related files into a library? This one could even be integrated as a submodule. (Right now I'm copying the files manually between 3 repositories, little bit annyoing and it's really easy to forget to merge changes back upstream)

btsimonh commented 5 years ago

happy to hear any proposal; I've not got experience in implementing a library in this architecture - have a play and see what you come up with....