search

bttmly / nba

Node.js client for nba.com API endpoints
MIT License
707 stars 180 forks source link

remove deprecated lodash.contains dependency #32

Closed brandly closed 7 years ago

brandly commented 7 years ago

happy new year, nick!

when installing packages that rely on this package, i'd get a npm WARN deprecated lodash.contains@2.4.3: This package is discontinued. Use lodash.includes@^4.0.0. warning.

i took a look at this repo, and lodash.contains isn't being used anymore, so i removed it with yarn remove lodash.contains.

yarn.lock experienced some churn, but maybe that's to be expected (i don't really understand yarn)

but this change should stifle that warning! thanks ⭐️

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 79.554% when pulling 2a229bb477cfb8a70caac69f5fc3f8ce89c3fd17 on brandly:patch-4 into df305a338e5fea304f2793a6a096cf35b11da7c3 on nickb1080:master.

bttmly commented 7 years ago

thanks -- good find!

bttmly commented 7 years ago

lodash.partial and lodash.assign were also unused, and now removed in latest