bttmly / nba

Node.js client for nba.com API endpoints
MIT License
710 stars 180 forks source link

players.json missing 2021 rookies #98

Closed domini7 closed 3 years ago

domini7 commented 3 years ago

Hey, having fun with this client. Noticed this years rookies aren't in players.json yet after trying to search for them. Just letting you know you.

bttmly commented 3 years ago

I'll make a release with updated players soon. You can always update the internal list of players at runtime by calling NBA.updatePlayers()

bttmly commented 3 years ago

~Weird! the players endpoint only seems to be returning the first 150ish players, rather than the 450ish you'd expect (30 teams * 15 spots)~

Thanks for the heads up! I needed to update the underlying JSON config for 2020-21 season. nba@4.14.0 has current players