Emote does not working in livestream or in vod

bttv-android / bttv

A mod of the Twitch Android Mobile App adding BetterTTV, FrankerFaceZ and 7TV emotes

MIT License

645 stars 21 forks source link

Emote does not working in livestream or in vod #633

Closed ecan18 closed 1 year ago

ecan18 commented 1 year ago

Existing Issues

[X] I have searched for existing issues, this is not a duplicate.

Unmodded Twitch

[X] I have checked and this issue only occurs using bttv-android and not with the unmodded Twitch App

What happened?

The emote does not working in livestream or in vod. For me to see the emote, i need to open and close the app several times.

bttv-android version

v0.40.1 beta

android version

device

Samsung s21 ultra

Anything else?

No response

welcome[bot] commented 1 year ago

Thank you for opening this issue ♥️ A maintainer should be by to give feedback soon. peepoArrive

Maj-ew commented 1 year ago

I confirm that as an issue but don't know for how long it has been, I even updated to newest version, still won't work

icynstant commented 1 year ago

Got this problem since week ago, maybe it has something to do with new Twitch updates or/and with Android 13.

zakary2841 commented 1 year ago

Also, I have this issue. If I had to guess I reckon it has to do with the V2 API being sunset on November 1st

Hopefully, this helps to speed up the diagnostic process 😊

zakary2841 commented 1 year ago

Just looked into this more. That is definitely the issue. https://github.com/bttv-android/bttv/blob/c0d227c610f5bc08f6287a69ffba0c8f6788a57a/mod/app/src/main/java/bttv/Network.java#L26

It will need replacing with the V3 API so I don't think it will be a quick fix. Especially if you are using the old username query as that has been removed.

FoseFx commented 1 year ago

Thank you everyone, especially @zakary2841 for identifying the root cause. Fix is rolling out now.