bttv-android / bttv

A mod of the Twitch Android Mobile App adding BetterTTV, FrankerFaceZ and 7TV emotes
MIT License
624 stars 21 forks source link

7tv emote that change name from 7tv global does not show #640

Closed ecan18 closed 11 months ago

ecan18 commented 11 months ago

Existing Issues

Unmodded Twitch

What happened?

The 7tv emote that change name from 7tv site in stream does not appear. Thanks for the work.

bttv-android version

v0.40.3 beta

android version

13

device

Samsung S21 ultra

Anything else?

No response

FoseFx commented 11 months ago

I'm having issues understanding the bug. Can you quickly summarize the problem? What needs to happen for it to occur?

ecan18 commented 11 months ago

Im sorry the issue fix. I think i need to to download the app again because in my other phone the app work perfectly

jraug44 commented 11 months ago

I have an S21 Ultra too and I can confirm I have the exact same issue. Any 7TV emotes that are renamed will only replace the original name and the changed name will not show the emote. Because of that it will often show the wrong emote or no emote at all. This was not an issue prior to the 7TV fix update; it worked just fine before. This seems like a device-specific issue (probably Samsung as it also happens on my S8); please fix this ASAP. Also I tried redownloading the app like the OP said and that didn't fix it.

FoseFx commented 11 months ago

I'm still not sure what is happening here. Can you give me a description on how to reproduce this?

jraug44 commented 11 months ago

There's isn't really anything you need to do to reproduce this, just go to any channel that has emotes renamed and some of them won't show correctly.

ecan18 commented 11 months ago

This is the example that i can show: photo_2023-11-06_16-10-43 this is not the correct emote name in that channel. and this is the correct emote name that from web . Screenshot 2023-11-06 160822 I think because some emote from channel have different name for 7tv emote than in the 7tv database cause it. Thank for the work.

jraug44 commented 11 months ago

That's not an example because non-global 7TV and FFZ emotes don't show up in the box when you type a colon. That's a BTTV emote. I found that same emote on the BTTV website. Screenshot_20231106_121313_Chrome I double-checked, non-global 7TV emotes don't show up in the box even if you used them.

zakary2841 commented 11 months ago

I also have this issue but in a different way. I would say the best way for me to reproduce/explain is as follows. Add emote to chat but rename it. The rename doesn't apply to the chat.

It's the way you are pulling the emote names from the API as I had a similar issue with my app.

I have added "catJAMHalloween" to my channel https://www.twitch.tv/zakary2841 7TV LINK

But the original creator called it "catJAM" so it shows up as "catJAM" not "catJAMHalloween"

When querying the emote set. You get the JSON data listed. If you go to element 43 the name is "catJAMHalloween" But if you keep expanding that JSON "data" the name is "catJAM" NOT "catJAMHalloween".

Hopefully, this helps with your troubleshooting. Let me know if I can explain it any other way :)