PEP8 Styling + Pythonic Refactors

btwael / superstring.py

A fast and memory-optimized string library for heavy-text manipulation in Python

MIT License

250 stars 11 forks source link

PEP8 Styling + Pythonic Refactors #7

Closed danielenricocahall closed 4 years ago

danielenricocahall commented 4 years ago

Edited to comply with PEP8 Styling Guidelines (as requested in https://github.com/btwael/superstring.py/issues/3), and refactored certain code to be more "pythonic" and follow typical Python programming patterns (i.e; https://docs.quantifiedcode.com/python-anti-patterns/). Some of the changes include:

names with underscores rather than camelcase
linting / spacing
one line assignments
check if not rather than equality with None
using for-else paradigm instead of loop + flag

btwael commented 4 years ago

So sorry everyone for this late reply, thank you @danielenricocahall for you contribution, @shane-kerr and @yoptar for the reviews, and @im-n1 for the issue (#3).