search

btwardow / FactorizationMachines.jl

Factorization Machines for Julia
Other
11 stars 6 forks source link

Matrix vector cleanup #11

Closed Hydrotoast closed 8 years ago

Hydrotoast commented 8 years ago

Some matrix/vector cleanup tasks:

  1. Use the sparse matrix API to iterate over the values/indices of sparse matrices: nzrange, rowvals, and nzval
  2. Use Vector and Matrix instead of Array{x, 1} and Array{x, 2}
  3. Use zero(x) and one(x) instead of 0 and 1 literals

Many of these changes are inspired by the Performance tips section of the Julia manual.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.06%) to 96.552% when pulling 6fb1c8159d3dcbf5fd1b31026330c297b76eae96 on Hydrotoast:matrix-vector-cleanup into 3016c1087bd0d46a901d954dd03942b9dcb9f7a9 on btwardow:master.