search

btzy / nativefiledialog-extended

Cross platform (Windows, Mac, Linux) native file dialog library with C and C++ bindings, based on mlabbe/nativefiledialog.
zlib License
698 stars 95 forks source link

Update minimum cmake version to 3.5 #113

Closed WerWolv closed 1 year ago

WerWolv commented 1 year ago

Support for CMake versions lower than 3.5 have been deprecated with the newer versions of CMake. Thus a warning is being printed to the console now when configuring projects that use nativefiledialog-extended:

CMake Deprecation Warning at lib/third_party/nativefiledialog/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

This PR updates the minimum required cmake version to 3.5. Seeing that this version came out almost 8 years ago, this shouldn't affect most projects depending on this library.

btzy commented 1 year ago

Thanks for the PR, I'm keen to merge this. There seems to be some build failures that appear to be unrelated (due to Clang being unable to compile a newer version of libstdc++).