search

btzy / nativefiledialog-extended

Cross platform (Windows, Mac, Linux) native file dialog library with C and C++ bindings, based on mlabbe/nativefiledialog.
zlib License
700 stars 96 forks source link

Replace Macros with Aliases #121

Closed ds5678 closed 11 months ago

ds5678 commented 11 months ago

This pull request is intended to address issues with creating wrappers in other languages. I made Utf8 function exports available on all platforms.

Supercedes #118

Resolves #117

btzy commented 11 months ago

Thanks! This looks okay in principle, but I think I'll want to add a CI build configuration to build with the NFD_NATIVE define, which currently isn't tested in CI. (I'll add this in a separate PR first, and then rebase this PR over that one.)

btzy commented 11 months ago

Hi, can you rebase this PR over the latest master branch please?

ds5678 commented 11 months ago

All good?

btzy commented 11 months ago

Thanks! Just one minor comment, and I'll merge it once that is changed. I suppose Clang/ObjC doesn't have attribute alias, but what you've done is fine as well, since it's just an implementation detail now.

btzy commented 11 months ago

Seems like NFD_PickFolderU8 is missing on nfd_gtk.cpp?