search

btzy / nativefiledialog-extended

Cross platform (Windows, Mac, Linux) native file dialog library with C and C++ bindings, based on mlabbe/nativefiledialog.
zlib License
598 stars 89 forks source link

CI bug? #124

Closed ds5678 closed 5 months ago

ds5678 commented 6 months ago

I've been working on generating automated builds for use in NuGet packages, and I noticed something in your build script:

https://github.com/btzy/nativefiledialog-extended/blob/b73cf4cdfc644deda95ceffb355a84b28a34bb88/.github/workflows/cmake.yml#L52

This appears to be a bug because it doesn't match the other ones in the file.

https://github.com/btzy/nativefiledialog-extended/blob/b73cf4cdfc644deda95ceffb355a84b28a34bb88/.github/workflows/cmake.yml#L46

https://github.com/btzy/nativefiledialog-extended/blob/b73cf4cdfc644deda95ceffb355a84b28a34bb88/.github/workflows/cmake.yml#L33

btzy commented 5 months ago

Thanks for the catch! Yes, this is definitely a bug.

btzy commented 5 months ago

Fixed by https://github.com/btzy/nativefiledialog-extended/commit/397c4ba9f41683d454e33a5888f1a5db5ff3af67.