search

bu-ist / bu-blocks

A repository for storing all BU WordPress blocks for the new WordPress editor
https://bu-ist.github.io/bu-blocks/
1 stars 0 forks source link

Button block needs better Link component #264

Open acketon opened 4 years ago

acketon commented 4 years ago

in the 5.4 fixes: https://github.com/bu-ist/bu-blocks/pull/256 the previous custom "link" component was breaking in the new version of WordPress. I replaced it temporarily by copying the link component from the Leadin block which displays in the sidebar.

A better fix would be to use the Link component in the toolbar like the default button block. (not the link "formatting" button on the Rich text field though)

ashleykolodziej commented 4 years ago

Use the URL popover component here per @acketon. It doesn't take up space in the editor.