bu-ist / responsive-foundation

A responsive front-end framework. Used by the Responsive Framework.
https://bu-ist.github.io/responsive-foundation/
1 stars 2 forks source link

The `$border:` variable to new file and position in compile list #267

Open saucyrooster opened 1 year ago

saucyrooster commented 1 year ago

Description

The $border variable located in foundation _config.scss settings should be moved to enable setting a global color based on the child theme.

Issue

By including the $border variable in the config settings we are declaring styles in a configuration file. Styles should not be included in any abstract files and only declare initial configurations. Currently the $border variable calls a color for the default configuration based on responsive-foundations inclusion of variables $color-grayscale-*.

Solution

Create and move the border variable declaration to a _base.scss partial and load after all abstract config files. ie

  1. _config.scss
  2. _vars.scss
  3. _colors.scss
  4. _functions.scss
  5. _mixins.scss
  6. _base.scss <-- $border: ;