bu-ist / responsive-framework

3 stars 0 forks source link

responsive_filter_category_lists causes errors with empty string delimiter #142

Open alana29s opened 5 years ago

alana29s commented 5 years ago

https://github.com/bu-ist/responsive-framework/blob/develop/inc/extras.php#L78

This function causes errors when using get_the_category_list. https://codex.wordpress.org/Function_Reference/get_the_category_list

The default WordPress function uses an empty string. When using the empty string the Responsive filter errors.

On line 78 recommend changing is_null( $separator ) to empty( $separator ) so filter exits properly if we have an empty string default separator.

Need to review this fix for side effects before implementing.

alana29s commented 5 years ago

screen shot 2019-01-23 at 5 01 02 pm