search

bu-ist / responsive-framework

3 stars 0 forks source link

Hide the homepage title should not remove homepage title from markup #50

Open amckenz opened 6 years ago

amckenz commented 6 years ago

From @ashleykolodziej on June 21, 2018 17:58

Responsive Version: 2.0

Expected behavior: The front page h1 should be visually hidden, but still present in the markup.

Actual behavior: Front page h1 gets totally removed from content altogether.

Removing the h1 altogether from the markup is really bad from both an accessibility and SEO perspective. We should keep the markup in, but instead, add a hide-homepage-title class that we can target to visually hide the title without interfering with screen readers.

This will be much easier after https://github.com/bu-ist/responsive-framework/issues/420 is added.

Copied from original issue: bu-ist/responsive-framework-1x#422

amckenz commented 6 years ago

From @ashleykolodziej on July 11, 2018 18:16

This issue was moved to bu-ist/responsive-framework#18

amckenz commented 6 years ago

From @ashleykolodziej on July 11, 2018 18:17

Reopening and adding to the backport milestone - this is critical for SEO and needs to be addressed in 1.0 too.

ashleykolodziej commented 3 years ago

This issue refers to hiding the homepage title using the Hide the Homepage Title setting in Customizer. BU Banners also automatically hides the title in certain situations. I'm not sure how these may overlap, but it's something to consider in your testing.