Fix inconsistencies with Site Icons

[amckenz]

From @desrosj on December 7, 2017 20:13

The current implementation of site icons and favicons is inconsistent and incomplete.

Currently, a favicon is only output by the theme if responsive_is_bu_domain() evaluates to false (not a BU domain name). The image icon that is output in this scenario also does not exist within the framework. The code snippet that displays that favicon is also in Flexi, leading me to believe that this needs to be updated.

Outside of this conditional statement, an Apple touch icon is displayed. This is present in the theme and is always displayed (it is a BU logo), regardless of it being a non-BU site.

The favicon is loading, but only because it exists in the root directory of the domain, and that is where the browser looks by default.

I propose replacing these inconsistent favicon implementations with a few things, one of them being WordPress' site icon feature.

• If a site is NOT on the BU domain, they would not have the ability to edit the template theme and drop in the favicon-g.ico file that is being loaded in the current implementation. For these sites, allowing them to use the WordPress site icon feature would be ideal. It allows them to upload their own logo to be served as an icon.
• If a site IS on the BU domain, they should still continue to receive the default curated icon from the root directory. But, we need to add the other missing icons. These tags will most likely need to be added to the header.php file of this theme.
  • <link rel="icon" href="image URL" sizes="192x192" />
  • <link rel="apple-touch-icon-precomposed" href="image URL 180x180" />
  • <meta name="msapplication-TileImage" content="270x720 version" />

Copied from original issue: bu-ist/responsive-framework-1x#284

[amckenz]

From @ashleykolodziej on December 8, 2017 14:37

👍 This is a great idea! Makes perfect sense to me. I can help with icons in the new year once Dining is off my plate.