search

buape / carbon

A fully-featured HTTP library for Discord bots
https://carbon.buape.com/
MIT License
12 stars 6 forks source link

Consistent options handler params #107

Closed thewilloftheshadow closed 1 month ago

thewilloftheshadow commented 1 month ago

Right now, mentionable and channel both return promises, while the rest do not. I'd like to standardize this to either all promises or all straight values (with the latter being preferred). Need to investigate more to see why I made them async originally

CleanShot 2024-09-15 at 20 58 11@2x

thewilloftheshadow commented 1 month ago

Blocked by #97 because that affects the await of getChannel Mentionable is async bc we fetch as a user then fetch as a role to see which it is

thewilloftheshadow commented 1 month ago

After digging through this, it seems like this is just an unfortunate side effect of our design decision of partials and only fetching data if it's actually needed.