Closed GoogleCodeExporter closed 9 years ago
Attached all the details.
Overall a good first patch. It needs some further tidying up, but no major
problems.
Original comment by Alberth2...@gmail.com
on 7 Mar 2013 at 9:30
Attachments:
Attached new version with the fixes. I think I got everything, but you should
double-check.
I've responded to a couple of the comments in the attached text file.
Original comment by AJBonko...@gmail.com
on 8 Mar 2013 at 5:38
Attachments:
Hi, I did a bit of editing and committed your patch (r660:r666). You may want
to compare it with the patch above.
While editing, I found Finances::GetTotal() weird, but I see now my comment is
wrong.
Personally, I don't care much about doing whatever the original was doing. Feel
free to improve where it's useful.
TABs at the start of the line has the nice advantage that everybody can have
his own favorite TABsize. I have made TAB and trailing whitespace visible in my
editor, which is *very* useful to see what'you're doing :)
I agree that a DVCS is very useful, I use hgsubversion for that. Moving the
main repository has a lot more consequences.
Original comment by Alberth2...@gmail.com
on 9 Mar 2013 at 1:04
An old style checker of OpenTTD that I wrote many years ago. It's not complete,
and only caught stuff I did wrong, but it may serve as a starting point to
catch your own common errors.
Original comment by Alberth2...@gmail.com
on 9 Mar 2013 at 1:06
Attachments:
Original comment by Alberth2...@gmail.com
on 9 Mar 2013 at 1:10
Original comment by CharlesP...@googlemail.com
on 6 Aug 2013 at 3:10
Original comment by CharlesP...@googlemail.com
on 25 Sep 2013 at 11:49
Original issue reported on code.google.com by
AJBonko...@gmail.com
on 6 Mar 2013 at 3:40Attachments: