Closed DonGideon closed 4 years ago
Merging #327 into master will not change coverage by
%
. The diff coverage isn/a
.
Impacted Files | Coverage Δ | |
---|---|---|
packages/stili/src/index.web.ts | 100.00% <ø> (ø) |
@deepsweet @xaviervia would really appreciate your input here... after that i will open a PR in Primitives to update the dependency of Stili after that... i will open a PR in Next to update the dependency of Primitives/Block after that i will go to sleep
The PR just fixes types and not normalizing anything, my guess was that there will be only array allowed and then it goes directly to styles on native and through a helper on web.
Also, I'd extract those transform types and not import react-native
in web
file even for types.
@deepsweet yes! but isn't the normalization happening here: https://github.com/bubble-dev/_/blob/6bb00f53bcfc27578f7f18e8848682bdcd776c75/packages/primitives/block/src/index.web.tsx#L73 ?
oh, then it should be extracted, I think it's more of a stili
responsibility @xaviervia
a simple change that will solve this:
<Block style={{ transform: [{ scale }] }}>
in web to not have a lint error: