search

bubble-dev / _

🍱 metarepo of many packages and various monorepos
52 stars 6 forks source link

🐣 primitives/progress-bar: init primitive progress bar #469

Closed DonGideon closed 3 years ago

DonGideon commented 3 years ago

this is a second approach to add a11y to progress bar, instead of having more props to Block we have a primitive-progress-bar https://github.com/bubble-dev/_/pull/468

Screenshot 2021-01-22 at 14 05 51

use case here: https://www.notion.so/klarnadesign/Bubble-next-Accessibility-81d1cc3a00a945e6a3f8ddab1d2cea1b

irminakacz commented 3 years ago

@DonGideon But you probably want to change the merge branch from ui-1280-add-accessibility-for-progressbar to master :)

@irmina, i'm trying to write here, instead of a new message. Yes, i kept it this way cause if someone would want to compare the two approche they can have both on the same branch (locally you can run sandbox and both solutions would work), i'll remove the extra code before margin to master 😊

moriaam commented 3 years ago

great pr! 🎉