search

bubenshchykov / ngrok

Expose your localhost to the web. Node wrapper for ngrok.
https://ngrok.com
2.33k stars 317 forks source link

NgrokClient.requestDetail missing Ngrok namespace in type definition #232

Closed theaussiepom closed 3 years ago

theaussiepom commented 3 years ago

When consuming the ngrok package with typescript for Node 14, compiler fails with error:

node_modules/ngrok/ngrok.d.ts:217:40 - error TS2304: Cannot find name 'Request'.
217     requestDetail(id: string): Promise<Request>;

Like 217 of ngrok.d.ts should read: 217 requestDetail(id: string): Promise<Ngrok.Request>;

theaussiepom commented 3 years ago

See pull request: https://github.com/bubenshchykov/ngrok/pull/233

philnash commented 3 years ago

Thanks for raising and fixing this! I'll get this merged later today.

theaussiepom commented 3 years ago

Awesome, thanks Phil

philnash commented 3 years ago

This is deployed as of version 4.1.0. Thanks!