buberdds / angular-bootstrap-colorpicker

Native AngularJS colorpicker directive. No dependency on jQuery or jQuery plugin is required.
MIT License
419 stars 226 forks source link

Add target attribute #23

Closed joscha closed 10 years ago

joscha commented 10 years ago

This PR adds a colorpicker-target attribute to the directive that allows to define where the color picker is going to be injected in the DOM. This is needed if the color picker is used in a fixed element. /cc @ldiercks

joscha commented 10 years ago

thanks @ldiercks

buberdds commented 10 years ago

Hi there,

thanks for your PR. Solution works great, but it needs jQuery. Looking up elements via selectors is not supported by jqLite. The main idea was to create a module without external dependencies.

btw there was an update and I hope the colorpicker now can be placed in a fixed elements.

joscha commented 10 years ago

@buberdds I see. Thank you very much for the updated version. I created a new PR #26 that leverages your changes.