search

buberdds / angular-bootstrap-colorpicker

Native AngularJS colorpicker directive. No dependency on jQuery or jQuery plugin is required.
MIT License
419 stars 226 forks source link

Change css images to base64 image urls #25

Closed rustygreen closed 10 years ago

rustygreen commented 10 years ago

Since there are only 3 small images for this project I think it makes sense to simply use their base64 image url in the css rather than point to a static image. By doing this, users would still have the ability to set static image urls, but it would be even easier to use the module without having to worry about copying the images over (or fixing the image path).

Since you already have the styling in a .less file, perhaps just using an image url variable and setting them to the base64 image url would do the trick.

I will create a pull request for this if you will approve the change?

buberdds commented 10 years ago

In a less file each image path is an argument for a less data-uri function. When you compile a less file it will generate base64 image url in the css. If you include the colorpicker.css file in your project you don't have to worry about paths and images.

Maybe I'm missing something, but in the css file there are only base64 image urls. You can always submit a PR, maybe this PR will open my mind for your issue :)

rustygreen commented 10 years ago

Sorry about that, I didn't look closely enough at the less file! That's perfect. Thanks!

Rusty Green | www.rustygreen.com http://www.rustygreen.com/?ref=gmail

rusty@rustygreen.com | (717) 831-8869

rustymgreen@gmail.com | rgreen@harrisburgu.edu

Sent from a mobile device. Please excuse brevity and typos.

On Tue, Dec 31, 2013 at 5:47 AM, buberdds notifications@github.com wrote:

In a less file each image path is an argument for a less data-uri function. When you compile a less file it will generate base64 image url in the css. If you include the colorpicker.css file in your project you don't have to worry about paths and images.

Maybe I'm missing something, but in the css file there are only base64 image urls. You can always submit a PR, maybe this PR will open my mind for your issue :)

— Reply to this email directly or view it on GitHubhttps://github.com/buberdds/angular-bootstrap-colorpicker/issues/25#issuecomment-31390711 .