buberdds / angular-bootstrap-colorpicker

Native AngularJS colorpicker directive. No dependency on jQuery or jQuery plugin is required.
MIT License
419 stars 226 forks source link

(proposal) Inline colorpicker #35

Closed clouddueling closed 10 years ago

clouddueling commented 10 years ago

So I needed a way to make the colorpicker inline and I thought I'd throw this up if you want it.

Inline:

<div ng-model='processCopy.color' colorpicker colorpicker-parent='true' colorpicker-template='inline'></div>

screen shot 2014-02-18 at 7 07 40 am

Normal: screen shot 2014-02-18 at 7 09 59 am

Code: https://gist.github.com/clouddueling/9072760 L268 L425

I'd love to make a PR but wanted to know what you thought on naming conventions and code organization.

buberdds commented 10 years ago

Hi @clouddueling ! I'm waiting for your PR. I think we can extract something like a "coreTemplate"

                                    '<colorpicker-saturation><i></i></colorpicker-saturation>' +
                                    '<colorpicker-hue><i></i></colorpicker-hue>' +
                                    '<colorpicker-alpha><i></i></colorpicker-alpha>' +
                                    '<colorpicker-preview></colorpicker-preview>' +

just not to repeat the same code in each template.

btw I can see that you are busy here on the github, but you may want to join as a collaborator, accelerate some changes here and of course you can mention about clouddueling in the readme file ;]

clouddueling commented 10 years ago

@buberdds I'm game we use this plugin constantly. I'll make some changes and add to the tests. Some of this stuff takes me a long (we're launching soon all attention is there)

buberdds commented 10 years ago

No hurry here. Good luck with the business.

buberdds commented 10 years ago

Cleaning old issues.