search

buberdds / angular-bootstrap-colorpicker

Native AngularJS colorpicker directive. No dependency on jQuery or jQuery plugin is required.
MIT License
419 stars 226 forks source link

fix for firefox #91

Closed jakubsikora closed 9 years ago

jakubsikora commented 9 years ago

Firefox doesn't have event.offsetX and event.offsetY which causing issues with colorpicker. This extra case fixing the problem in FF.

HHogg commented 9 years ago

:+1:

kasparasg commented 9 years ago

:+1:

OrganicPanda commented 9 years ago

:+1:

rvijayan commented 9 years ago

:+1:

buberdds commented 9 years ago

I had to remove your prevoius commit. This one is not working correctly in browsers too. Can you please validate if your fixes are working correctly in FF and IE too? thanks

jakubsikora commented 9 years ago

@buberdds sorry man. I can't do primary math apparently :) It should work now. Tested on IE10/11, FF, and Chrome.

kasparasg commented 9 years ago

@jakubsikora maybe you could also include a test in here :wink: @buberdds thanks for review! :wink:

buberdds commented 9 years ago

np @jakubsikora, thanks for another update. I will test it asap