bubibubi / sqliteef6migrations

System.Data.SQLite.EntityFramework.Migrations - Migrations for SQLite Entity Framework provider
Microsoft Public License
40 stars 20 forks source link

Unable to extend SQLiteMigrationSqlGenerator #9

Closed pippolino closed 5 years ago

pippolino commented 5 years ago

The SQLiteMigrationSqlGenerator is sealed class and cannot extend. It's possible remove sealed ?

bubibubi commented 5 years ago

I think so. If the extensions are related to EF you could work on the base class. If you make some fixes or enhancements I will include them in master.

pippolino commented 5 years ago

Hi @bubibubi, I understand, but also Microsoft has made the class extendable SqlServerMigrationSqlGenerator. The changes that do not concern the EF can not be put on the master but are customization of a project.

bubibubi commented 5 years ago

@pippolino you can download the new version that includes this fixes from NuGet. Greetings from Bologna!

pippolino commented 5 years ago

Thanks ... Same version 1.0.104 or 1.0.105 ?

bubibubi commented 5 years ago

105

pippolino commented 5 years ago

I do not see that version on nuget

bubibubi commented 5 years ago

Ops... Probably something went wrong during compile...

bubibubi commented 5 years ago

Now you should find it. It was a wrong nuget version.

pippolino commented 5 years ago

Now you should find it. It was a wrong nuget version.

Thanks!!!!

Greetings from Florence!