search

bubjavier / react-native-dfp

A react-native bridge for Google Mobile Ads' DFP libraries
13 stars 12 forks source link

Remove the use of the now deprecated React.Proptypes and createJSModules method #2

Closed adrienthiery closed 6 years ago

adrienthiery commented 6 years ago

On react-native@0.49.*, it now fails instead of giving a warning

Could be interesting to release that as a new major (v1.0.0) because it is kind of a breaking change

adrienthiery commented 6 years ago

@bubjavier : Any insights on that ?

Do you mind me merging it?

bubjavier commented 6 years ago

thanks @adrienthiery, sure, go with the merge.