bubkoo / html-to-image

βœ‚οΈ Generates an image from a DOM node using HTML5 canvas and SVG.
MIT License
5.66k stars 524 forks source link

Extension less images are not loading #303

Open MudasirGhouri opened 2 years ago

MudasirGhouri commented 2 years ago

I'm using html-to-image to convert my certain component to image. My component contains some images which are placed in tag. As images are rendering fine in browser but for some reason when my html is converted to image. Some of the image links are broken (don't show images). After inspecting I noticed that the images which are not rendering are the images without extension. My code so far:

htmlToImage.toPng(ref.current)
      .then((dataUrl) => {
        const link = document.createElement("a");
        link.download = "my-image-name.jpg";
        link.href = dataUrl;
        link.click();
      })
vivcat[bot] commented 2 years ago

πŸ‘‹ @mudasirVS

Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

vivcat[bot] commented 2 years ago

Potential duplicates:

vivcat[bot] commented 2 years ago

Hiya! This issue has gone quiet. Spooky quiet. πŸ‘» We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this issue open! As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.

Thanks for being a part of the Antv community! πŸ’ͺπŸ’―

samrun0 commented 1 year ago

Same issue! Any updates on this?

samrun0 commented 1 year ago

Solved the issue of image tags not showing up in the final image output by making sure images are loaded and toPNG is called in onload event.

samrun0 commented 1 year ago

So this is not a bug...