bubkoo / html-to-image

✂️ Generates an image from a DOM node using HTML5 canvas and SVG.
MIT License
5.41k stars 505 forks source link

Fix Safari images #325

Closed merapi closed 1 year ago

merapi commented 1 year ago

Description

We have found & fix this issue in Safari: https://github.com/GoogleForCreators/web-stories-wp/issues/12432

decode() support is great so we probably don't need a fallback, but I'm happy to hear your thoughts.

Also, I think the readme should be updated because it works pretty well in Safari.

Motivation and Context

Types of changes

Self Check before Merge

codecov[bot] commented 1 year ago

Codecov Report

Base: 67.05% // Head: 67.05% // No change to project coverage :thumbsup:

Coverage data is based on head (8a51ae5) compared to base (471ad8d). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #325 +/- ## ======================================= Coverage 67.05% 67.05% ======================================= Files 10 10 Lines 513 513 Branches 119 119 ======================================= Hits 344 344 Misses 120 120 Partials 49 49 ``` | [Impacted Files](https://codecov.io/gh/bubkoo/html-to-image/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=%E5%B4%96) | Coverage Δ | | |---|---|---| | [src/embed-images.ts](https://codecov.io/gh/bubkoo/html-to-image/pull/325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=%E5%B4%96#diff-c3JjL2VtYmVkLWltYWdlcy50cw==) | `96.66% <100.00%> (ø)` | | | [src/util.ts](https://codecov.io/gh/bubkoo/html-to-image/pull/325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=%E5%B4%96#diff-c3JjL3V0aWwudHM=) | `63.47% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=%E5%B4%96). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=%E5%B4%96)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

vivcat[bot] commented 1 year ago

:tada: This PR is included in version 1.10.10 :tada:

The release is available on:

Your semantic-release bot :package::rocket: