toBlob error when image not found

liu-xinhui commented 1 year ago

Expected Behavior

Do not show error, when image not found ,make it empty

Current Behavior

show error and not create image

Possible Solution

Steps To Reproduce

...
...
...

Error Message & Stack Trace

```txt ```

Additional Context

Your Environment

html-to-image: [1.10.8]
OS: [macOS monterey 12.5.1]
Browser: [chrome 107.0.5304.110 (arm64)]

const blob = await toBlob(document.getElementById("designer-board") as any, { pixelRatio: 0.5 });
const file = new window.File([blob], "screenshot.jpg", { type: "image/jpeg" });
return (await uploadFile(file));

vivcat[bot] commented 1 year ago

👋 @liu-xinhui

Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

yairbar commented 1 year ago

it's happened to me too,

https://github.com/bubkoo/html-to-image/blob/master/src/embed-images.ts#L27

need to fix

!isDataUrl(clonedNode.src) => !isDataUrl(clonedNode.src || '')

for cases there is not 'src' in <img> element

bubkoo / html-to-image