Closed haodaking closed 1 year ago
👋 @haodaking
💖 Thanks for opening this pull request! 💖
Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.
Examples of commit messages with semantic prefixes:
fix: don't overwrite prevent_default if default wasn't prevented
feat: add graph.scale() method
docs: graph.getShortestPath is now available
Things that will help get your PR across the finish line:
npm run lint
locally to catch formatting errors earlier.We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
Base: 63.24% // Head: 63.24% // No change to project coverage :thumbsup:
Coverage data is based on head (
130f2f9
) compared to base (7a83b54
). Patch coverage: 60.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks for this PR and finding the core issues. I've decided to make my own PR (https://github.com/bubkoo/html-to-image/pull/352) as I feel in some ways I've introduced this issue. I am not sure on the etiquette of conflicting PR's in open source. Sorry if I stepped on toes but I prefer to create my own PR in this case. I felt the tagName
approach although effective could maybe be adjusted to use something more generic, and I also didn't see a need for a few other changes in the PR. So I made mine to focus on what I considered required to complete my original PR where I claimed to add iframes as a whole.
Thanks for this PR and finding the core issues. I've decided to make my own PR (#352) as I feel in some ways I've introduced this issue. I am not sure on the etiquette of conflicting PR's in open source. Sorry if I stepped on toes but I prefer to create my own PR in this case. I felt the
tagName
approach although effective could maybe be adjusted to use something more generic, and I also didn't see a need for a few other changes in the PR. So I made mine to focus on what I considered required to complete my original PR where I claimed to add iframes as a whole.
Thank you, I think your code implementation is more elegant and learning.
This pull request addresses the issue with capturing iframes in the library, where the resulting images were blank or incorrect.
Description
https://stackoverflow.com/questions/26248599/instanceof-htmlelement-in-iframe-is-not-element-or-object
Motivation and Context
Types of changes
Self Check before Merge