Closed AndrewN93 closed 1 year ago
π @AndrewN93
π Thanks for opening this pull request! π
Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.
Examples of commit messages with semantic prefixes:
fix: don't overwrite prevent_default if default wasn't prevented
feat: add graph.scale() method
docs: graph.getShortestPath is now available
Things that will help get your PR across the finish line:
npm run lint
locally to catch formatting errors earlier.We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
Base: 63.24% // Head: 63.24% // No change to project coverage :thumbsup:
Coverage data is based on head (
6bac4a4
) compared to base (1933175
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
π @AndrewN93 Congrats on merging your first pull request! πππ
:tada: This PR is included in version 1.11.5 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
There is a difference between values in actual d attribute of path and value that returns from window.getComputedStyles() object For some generated svg shapes at particular place is crutial to have exact values in order them to be displayed at all.
Closes #357
Description
There is a problem appears for
path
elements with precise values ind
attribute on cloneCSSStyle step.window.getComputedStyles()
which is used to get styles to apply them on cloned element returns rounded values which is wrong for some elements. For e.g here I'm inspecting cloned element and the elements are actually present but because of rounded values after styles were copied they are invisible with height 0 and width 0:Types of changes
Self Check before Merge