Closed DustinBrett closed 1 year ago
Base: 63.24% // Head: 63.24% // No change to project coverage :thumbsup:
Coverage data is based on head (
ce892e6
) compared to base (1933175
). Patch coverage: 0.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
:tada: This PR is included in version 1.11.5 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
I noticed an issue with my images not loading. I traced it to neither
onload
oronerror
firing during theembedImageNode
step, which I was able to fix by changing theloading
(https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#attr-loading) attribute toeager
instead oflazy
as my images are.Description
Add a condition during
embedImageNode
that changes lazy loading images to eager to ensure (ideally) that onload/onerror fires.Motivation and Context
This problem occurs at least for me when I have an
img
which hasloading
(https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#attr-loading) set tolazy
. Changing this toeager
stops the problem, so I've made this adjustment occur during cloning as we would not want to lazy loading images when we are trying to clone them and are waiting for them to finish decoding/loading.Types of changes
Self Check before Merge