bubkoo / html-to-image

✂️ Generates an image from a DOM node using HTML5 canvas and SVG.
MIT License
5.69k stars 531 forks source link

why add this breaking chang in this version #365

Closed mochen666 closed 1 year ago

mochen666 commented 1 year ago

image

vivcat[bot] commented 1 year ago

👋 @mochen666

Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

bubkoo commented 1 year ago

@mochen666 Why it's a breaking change?

TouqeerH commented 1 year ago

@mochen666 Why it's a breaking change?

This change is breaking yarn. As it requires pnpm which many of us do not use.

preinstall runs wheneveryarn or npm i is executed. This requires any project that uses this library to have pnpm installed.

Fawwad-Khan commented 1 year ago

Also facing the same issue.

txemaleon commented 1 year ago

Hi!

Also facing this

The problem is your pre-install hook is running npx only-allow pnpm which breaks installs on packages dependant on html-to-image.

While I understand this is good intentioned, I'd appreciate if you could revert the change in the pre-install hook, as it is not needed after publishing the package and it's effectively prohibiting the installation in every non-pnpm environment.

Thanks! Hope this helps you

thealonekhan commented 1 year ago

Facing same issue

carlosg-ordering commented 1 year ago

Same issue here

chrislondon commented 1 year ago

same here

ddelpiano commented 1 year ago

same here

sandi-buchanan commented 1 year ago

Same issue being encountered in our project with version 1.11.9.

txemaleon commented 1 year ago

If anyone gets here trough google, you have to update to v1.11.10 at least to fix this problema

bubkoo commented 1 year ago

v1.11.9 was marked as deprecated.

image

vivcat[bot] commented 7 months ago

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.