bubkoo / html-to-image

βœ‚οΈ Generates an image from a DOM node using HTML5 canvas and SVG.
MIT License
5.4k stars 505 forks source link

fix(mask): add support for -webkit-mask and -webkit-mask-image #382

Open amiratak88 opened 1 year ago

amiratak88 commented 1 year ago

Description

Add support for mask and mask-image properties for browsers that support them via webkit.

Motivation and Context

Types of changes

Self Check before Merge

vivcat[bot] commented 1 year ago

πŸ‘‹ @amiratak88

πŸ’– Thanks for opening this pull request! πŸ’–

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

Things that will help get your PR across the finish line:

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 75.00% and no project coverage change

Comparison is base (b751cbf) 62.93% compared to head (569a944) 62.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #382 +/- ## ======================================= Coverage 62.93% 62.93% ======================================= Files 10 10 Lines 580 580 Branches 143 143 ======================================= Hits 365 365 Misses 151 151 Partials 64 64 ``` | [Impacted Files](https://codecov.io/gh/bubkoo/html-to-image/pull/382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=%E5%B4%96) | Coverage Ξ” | | |---|---|---| | [src/embed-images.ts](https://codecov.io/gh/bubkoo/html-to-image/pull/382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=%E5%B4%96#diff-c3JjL2VtYmVkLWltYWdlcy50cw==) | `78.04% <75.00%> (ΓΈ)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=%E5%B4%96). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=%E5%B4%96)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lorenzhh commented 12 months ago

What is the status of this PR?

gilkeyio commented 1 month ago

Would love to see this get merged! I've run a local fork with these changes, and they work great for me.