bubkoo / html-to-image

βœ‚οΈ Generates an image from a DOM node using HTML5 canvas and SVG.
MIT License
5.39k stars 503 forks source link

feat: cache request itself #430

Open Colin3191 opened 10 months ago

Colin3191 commented 10 months ago

Description

Cache the requests themselves to optimize the case of a large number of resource requests in a short period of time #429

Motivation and Context

Types of changes

Self Check before Merge

vivcat[bot] commented 10 months ago

πŸ‘‹ @Colin3191

πŸ’– Thanks for opening this pull request! πŸ’–

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

Things that will help get your PR across the finish line:

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (b751cbf) 62.93% compared to head (b261446) 62.93%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #430 +/- ## ======================================= Coverage 62.93% 62.93% ======================================= Files 10 10 Lines 580 580 Branches 143 143 ======================================= Hits 365 365 Misses 151 151 Partials 64 64 ``` | [Files Changed](https://app.codecov.io/gh/bubkoo/html-to-image/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=%E5%B4%96) | Coverage Ξ” | | |---|---|---| | [src/dataurl.ts](https://app.codecov.io/gh/bubkoo/html-to-image/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=%E5%B4%96#diff-c3JjL2RhdGF1cmwudHM=) | `60.00% <50.00%> (ΓΈ)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.