Open uramacharles opened 7 months ago
👋 @uramacharles
💖 Thanks for opening this pull request! 💖
Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.
Examples of commit messages with semantic prefixes:
fix: don't overwrite prevent_default if default wasn't prevented
feat: add graph.scale() method
docs: graph.getShortestPath is now available
Things that will help get your PR across the finish line:
npm run lint
locally to catch formatting errors earlier.We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
b751cbf
) 62.93% compared to head (0fb2242
) 62.93%. Report is 3 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
src/dataurl.ts | 0.00% | 1 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
IOS (Safari) devices requests credentials to be sent across on all fetch request. That makes all requests that doesn't have the pre-defined credentials to fail. However, when the credential is set as true with the fetchRequestInit interface, Images are loaded well, but the fonts is blocked. This is because fonts.gstatic.com makes use of wildcard as their Access-Control-Allow-Origin, which doesn't go at same time with when the credentials is set to 'include'. Thus the proposal of creating a different interface "fetchFontRequestInit" which will be used on embed-webfonts.ts. This also adds to the flexibility to the library
Motivation and Context
I encountered this issue while working on a project that requires me convert html to images. I checked through the communities, but I couldn't seeing any solution that worked for me. So I decided to check through it. That's how I came to this solution.
Bellow are some of the common open issues.
To Fix this Problem,
url(${result})
) return [loc, result] }, ) ...Types of changes
Self Check before Merge