Open misino opened 4 months ago
👋 @misino
💖 Thanks for opening this pull request! 💖
Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.
Examples of commit messages with semantic prefixes:
fix: don't overwrite prevent_default if default wasn't prevented
feat: add graph.scale() method
docs: graph.getShortestPath is now available
Things that will help get your PR across the finish line:
npm run lint
locally to catch formatting errors earlier.We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
b751cbf
) 62.93% compared to head (3b6fd62
) 63.10%. Report is 11 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
src/embed-images.ts | 50.00% | 1 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
…d up in the exception
Description
Motivation and Context
We had a problem with generating an image when html contained pictures with src pointing to a domain which doesn't allow CORS. This change is about possibility to specify own onerror callback which don't need to make whole image generation fail.
Types of changes
Self Check before Merge