toBlob won't save to a jpeg

bubkoo / html-to-image

✂️ Generates an image from a DOM node using HTML5 canvas and SVG.

MIT License

5.39k stars 503 forks source link

toBlob won't save to a jpeg #458

Open funkyvisions opened 3 months ago

funkyvisions commented 3 months ago

Expected Behavior

toBlob(node, { type: "image/jpeg" }) should get a blob with a jpeg embedded

Current Behavior

toBlob(node, { type: "image/jpeg" }) is always embedding a png

Possible Solution

toBlob is calling canvasToBlob WITHOUT the options

Steps To Reproduce

const blob = await htmlToImage.toBlob(elem, { type: "image/jpeg" })

Blob has type "image/png"

Additional Context

Your Environment

html-to-image: 1.11.11
OS: macOS Sonoma 14.4
Browser: Chrome

vivcat[bot] commented 3 months ago

👋 @funkyvisions

Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.