Open jagermesh opened 2 months ago
š @jagermesh
š Thanks for opening this pull request! š
Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.
Examples of commit messages with semantic prefixes:
fix: don't overwrite prevent_default if default wasn't prevented
feat: add graph.scale() method
docs: graph.getShortestPath is now available
Things that will help get your PR across the finish line:
npm run lint
locally to catch formatting errors earlier.We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
Sorry, not sure what is wrong with Label step, but fix worth to review. It's significantly improve the speed in case when HTML contain SVG images.
Attention: Patch coverage is 20.00000%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 63.10%. Comparing base (
b751cbf
) to head (b672638
). Report is 12 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
src/clone-node.ts | 20.00% | 2 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Optimize cloning of SVG elements
Description
Instead of cloning each child SVG element (which in my case is around 200) we can use cloneNode(true) to use deep clone mode
Motivation and Context
Converting DIV with SVG inside taking around 20 second in Safari and around 15 in Chrome
Types of changes
Self Check before Merge