bucanero / apollo-ps3

Apollo Save Tool (PS3)
http://www.bucanero.com.ar/
GNU General Public License v3.0
357 stars 23 forks source link

Apollo improperly adds "System" attribute to exported files when copying to USB #125

Closed DeepMac closed 7 months ago

DeepMac commented 10 months ago

Discovered copying some files from a PS3 to USB, using Apollo, will improperly add the "System" attribute to the files. Examples:

On Windows computers, the System attribute is a legacy bit set that will hide the file from view in Windows explorer, and will return "file not found" errors when attempting to interact with the files in a CMD or Powershell interface. Only if a user has explicitly enabled the options in Windows Explorer to show Hidden AND System files will they be visible and copyable.

bucanero commented 9 months ago

Right, I haven't used Windows in ages so I missed this one.

A good thing would be to get a complete list of all the exported USB files that could get this system attribute so when I work on a fix I don't miss some edge case.

Could you confirm if this happens for other USB exports, like .Zips, saves, etc+++

DeepMac commented 8 months ago

Can confirm it did it for all the file types listed in the original report. I'll test ZIP files. I don't think it did it for saves but I'll double-check. Probably you just want to always make sure the bitmask for the FAT32 attribs never has System set, because it's definitely never going to be needed or justifiable for this application.

DeepMac commented 8 months ago

Can confirm it adds system attribute to ZIP files, along with the TXT and XML files created exporting to ZIP (for HDD Save Games)

image

DeepMac commented 8 months ago

Forgot to add to original report, this was on the latest release, v1.8.4 on a PS3 slim

bucanero commented 8 months ago

Can confirm it adds system attribute to ZIP files, along with the TXT and XML files created exporting to ZIP (for HDD Save Games)

thanks for providing all the details and testing all the different export files. I'll get this fixed in the next release. I might ping for testing as I don't have a Windows pc around and a virtual machine might not provide the best results.

DeepMac commented 8 months ago

No worries, I'll keep my PS3 handy for now.

bucanero commented 7 months ago

what version of windows are you using that shows this System attribute? I'm currently testing on Windows 7, I also have a Win10 virtual machine but I wonder if you're using some older version like Win XP and maybe newer versions don't care about that S flag.

DeepMac commented 7 months ago

I use Windows 10, specifically: Microsoft Windows [Version 10.0.19044.3086]

It's a file-system attribute that is supported on FAT and NTFS systems. If you have a new version you want me to test for you happy to help, I'll have some free time this week.

bucanero commented 7 months ago

@DeepMac , can you try this Apollo build? https://www.mediafire.com/file/gwrz09ol62tw94w/apollo-ps3.pkg/file

I have fixed the FAT32 attribute and on my tests (with Windows 7) all files are ok. (tested with saves, trophies, .Zips, .raps, idps.hex, saves from online DB)

Having an additional test and confirmation with your PS3 and your Windows PC would be very helpful. Let me know if everything works or if you find any case where the S attribute is still tagged on the USB file.

bucanero commented 7 months ago

fixed in 1648b4a74ff05c5bdf32b205785372c258684205

DeepMac commented 7 months ago

@DeepMac , can you try this Apollo build? https://www.mediafire.com/file/gwrz09ol62tw94w/apollo-ps3.pkg/file

Tested, works like a champ. I do miss the doggos in the splash screen tho...

I have fixed the FAT32 attribute and on my tests (with Windows 7) all files are ok. (tested with saves, trophies, .Zips, .raps, idps.hex, saves from online DB)

Confirmed here too. All attribs look fine.

bucanero commented 7 months ago

@DeepMac , can you try this Apollo build? https://www.mediafire.com/file/gwrz09ol62tw94w/apollo-ps3.pkg/file

Tested, works like a champ. I do miss the doggos in the splash screen tho...

Thanks for testing, the fix will be in the new 1.8.6 version 👍

About my dogs, they're still in the app. 🐶 I made a little easter egg for them. Just open the "About" menu, and then press SELECT. A picture of them, and a short message will show up. (then you can press Circle to go back to the main menu)