search

bucanero / ps3iso-utils

Windows, Linux, and macOS builds of Estwald's PS3ISO utilities
http://www.bucanero.com.ar/
GNU General Public License v3.0
173 stars 12 forks source link

Version Descriptor Set Terminators must be set to 1, not 0 #5

Open sahlberg opened 2 years ago

sahlberg commented 2 years ago

Makeps3iso currently creates ISO images with VDST==0, which is invalid. It has to be set to 1.

The python library pycdlib has a workaround for this issue: https://github.com/clalancette/pycdlib/issues/99 but this should also be fixed in makeps3iso since other tools might also do this check to validate the ISO and break.

bucanero commented 1 year ago

I totally missed this issue. I'll take a look and see if I can update the VDST value.

Edit: also I'd check if PS3 backup managers work correctly if the ISOs have VDST=1 before doing any changes. Because in the end, the main goal is to use these ISOs on the PS3, and if managers expect the value to be zero, then it would be a headache.

bucanero commented 1 year ago

I'm not sure, but it seems that the value is actually set to 1 here?

https://github.com/bucanero/ps3iso-utils/blob/878090980a9042c61901920fed1b034af215e8c7/makeps3iso/makeps3iso.c#L2196

sahlberg commented 1 year ago

I'm not sure, but it seems that the value is actually set to 1 here?

https://github.com/bucanero/ps3iso-utils/blob/878090980a9042c61901920fed1b034af215e8c7/makeps3iso/makeps3iso.c#L2196

I don't know the internal structure of DVDs well enough to tell if that is the VDST that pycdlib complained about or if it is a different field. Pycdlib has a workaround that solves the issues for me so I am fine if you just want to close this issue. (and if no one else has ever reported an issue with this, it can't be all that many people that were affected in the first place.) Since a workaround exists it might not be worth the effort to dig into this any deeper.