search

bucardo / dbdpg

Perl Postgres driver DBD::Pg aka dbdpg
48 stars 35 forks source link

Drop support for PostgreSQL before 8.0 #43

Closed ilmari closed 5 years ago

ilmari commented 5 years ago

We currently (since 2007) support PostgreSQL back to version 7.4, which has been out of support upstream since 2010. By dropping support for versions before 8.0 we can get rid of several bits of cruft:

ilmari commented 5 years ago

I did some work to actually make it possible to run the tests on 7.4 (but a bunch of them fail), and fixed everything to work on 8.0.

ilmari commented 5 years ago

I've now merged the fixes for versions back to 8.0, so this PR only has the changes to drop 7.4 support.

@turnstep do you have an opinion on what the minimum supported version should be?

turnstep commented 5 years ago

My opinion is the same: support as far back as possible, until it becomes an undue burden or technically infeasible to support specific versions. But I'm fine with dropping 7.4 support. :)

ilmari commented 5 years ago

I take that as an okay to merge this PR?

On a related note we really should set up some CI (Travis, Circle, whatever) to automatically test on every version we claim to support, so we don't accidentally break them again.

turnstep commented 5 years ago

Yes, I'm fine with the merge. Some sort of CI would certainly be nice, although I'm out of tuits.

On Wed, Jan 9, 2019 at 5:55 PM Dagfinn Ilmari Mannsåker < notifications@github.com> wrote:

I take that as an okay to merge this PR?

On a related note we really should set up some CI (Travis, Circle, whatever) to automatically test on every version we claim to support, so we don't accidentally break them again.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bucardo/dbdpg/pull/43#issuecomment-452900550, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFFgw4bt0JbyN9dKthLz6qPig_rn6x5ks5vBnNogaJpZM4ZlkbS .