refs #44: show ParamValues also when do() syntax is used

bucardo / dbdpg

Perl Postgres driver DBD::Pg aka dbdpg

48 stars 36 forks source link

refs #44: show ParamValues also when do() syntax is used #52

Closed dk closed 5 years ago

dk commented 5 years ago

Hi,

Here I'm trying to show ParamValues in do() calls, that wasn't possible before as do() and fetch(ParamValues) was done outside in the DBI.xs. I'm using the temporary nature of $sth created inside DBD::Pg::db::do(), that is cleaning up link between $sth and $dbh needed to display the ParamValues.

Hope that makes sense /dk

dk commented 5 years ago

Other than this looks fine. How do we proceed from here? Could you apply the revised code, or should I file a new or updated pull request?

turnstep commented 5 years ago

Let's keep going the git(hub) way: make some changes to this branch and then push it out. Three things I think need addressing:

Simplify the code and don't worry about saving/restoring previous sth. It's very short-lived and there will never be more than one.
Pg.pm docs
That one typo :)

dk commented 5 years ago

Kindly check out if it's okay now

turnstep commented 5 years ago

Coming along nicely! Still needs a ParamValues inside the Database Handle Attribute section.

turnstep commented 5 years ago

Also give yourself credit in the Changes file!

dk commented 5 years ago

Here's some more, please take a look

greg-binary commented 5 years ago

If you can clear up the conflict with the "Changes" file, I can merge this in.

dk commented 5 years ago

I did merge the changes for 3.8.1. Github still though shows "conflict".