search

bucardo / dbdpg

Perl Postgres driver DBD::Pg aka dbdpg
48 stars 36 forks source link

Replace use of "vars" with "our" #75

Closed JRaspass closed 3 years ago

JRaspass commented 4 years ago

Use of this pragma is discouraged in favour of "our" under v5.6+ and this dist depends on v5.8+.

my rather than our in Makefile.PL seemed more logical.

turnstep commented 3 years ago

Looks good, but could you rebase? It's complaining about some whitespace in README.dev. There are also a few minor complaints from t/99_perlcritic.t when I tried it out.

JRaspass commented 3 years ago

@turnstep rebased and fixed the Critic violations, my bad I wasn't using AUTHOR_TESTING=1 before.