search

bucc-dev / bucc-notification

This repo contains excellently written code for the BUCC notification service
MIT License
0 stars 1 forks source link

Api key generation function and middleware validation #13

Closed Tu-Code closed 8 months ago

Tu-Code commented 8 months ago

Completed issues #2 and #7

Alfred-Onuada commented 8 months ago

Thanks, @Tu-Code, I didn't get a notification from Github on this, that's why I am just seeing it today 😣, Nice work. I'll fix a date so we can all with @tecnosam review and then get this PR approved.

Alfred-Onuada commented 8 months ago

Also move this tasks into the "In Review" column on the github projects

Alfred-Onuada commented 8 months ago

@Tu-Code can you change the PR to merge into dev please, thanks

Tu-Code commented 8 months ago

I tried but it’s saying there’s no difference between the branches and can’t create the PR. I apologize for the late response. I’m trying to lint my code now but I’m facing some version issues, I’ll send a PR then to see if it works once I’ve updated it.

On Thu, 8 Feb 2024 at 8:58 AM, inspectorGadget @.***> wrote:

@Tu-Code https://github.com/Tu-Code can you change the PR to merge into dev please, thanks

— Reply to this email directly, view it on GitHub https://github.com/bucc-dev/bucc-notification/pull/13#issuecomment-1933536485, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT5O66O4UFXXHJLAB5MWI6LYSSARXAVCNFSM6AAAAABCU2F6USVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTGUZTMNBYGU . You are receiving this because you were mentioned.Message ID: @.***>

Tu-Code commented 8 months ago

I've sent the PR to dev and linted my code, @Alfred-Onuada.