search

bucharest-gold / lightbright

NO LONGER MAINTAINED: A utility providing filters for asynchronous hooks in process.binding('async_wrap')
0 stars 3 forks source link

Please Don't Merge - Throwing an Error when no filters in use. #12

Closed helio-frota closed 8 years ago

helio-frota commented 8 years ago

Related to bucharest-gold/lightbright#10

To avoid to get a bit lost when no results are showing.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+7.1%) to 100.0% when pulling d6d0528458eb725c096b959512975ee8ef13591e on helio-frota:lightbright-10 into a6b49200d0d67cebc0625d157643ee7225bf1e51 on bucharest-gold:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+7.1%) to 100.0% when pulling d6d0528458eb725c096b959512975ee8ef13591e on helio-frota:lightbright-10 into a6b49200d0d67cebc0625d157643ee7225bf1e51 on bucharest-gold:master.

helio-frota commented 8 years ago
  1. CI is green but this is wrong: https://travis-ci.org/bucharest-gold/lightbright/jobs/172103924
  2. I ran the make command in a small window in the terminal and could not see the errors.
  3. I'm not following this:
Error: You need to add a filter to be able to get the results.
    at Object.activate [as enable] (/mnt/datadisk/lightbright/lib/trace_hooks.js:8:11)
    at Object.<anonymous> (/mnt/datadisk/lightbright/test/test-filter-reactivation.js:13:13)

This is a Foo filter right ? I mean this Foo should work. https://github.com/bucharest-gold/lightbright/blob/master/test/test-filter-reactivation.js#L12

I'm trying to understand why this is throwing the error for this.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+7.1%) to 100.0% when pulling e350b1b6ef8dcf0fe232055daa47939c95cf055e on helio-frota:lightbright-10 into a6b49200d0d67cebc0625d157643ee7225bf1e51 on bucharest-gold:master.